Skip to content

[#IOPID-2514] upgrade to node20 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 8, 2025
Merged

[#IOPID-2514] upgrade to node20 #166

merged 5 commits into from
Jan 8, 2025

Conversation

arcogabbo
Copy link
Contributor

List of Changes

  • upgraded to node20

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOPID-2514

@arcogabbo arcogabbo changed the title upgraded to node20 [#IOPID-2514] upgrade to node20 Jan 7, 2025
@arcogabbo arcogabbo marked this pull request as ready for review January 7, 2025 14:37
@arcogabbo
remove unused nvmrc
82e6af6 
.node-version file replaces it
gquadrati
gquadrati approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arcogabbo arcogabbo merged commit 19c61cd into master Jan 8, 2025
6 checks passed
@arcogabbo arcogabbo deleted the node20-upgrade branch January 8, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner

@gunzip gunzip Awaiting requested review from gunzip gunzip is a code owner

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner

@AleDore AleDore Awaiting requested review from AleDore AleDore is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcogabbo @gquadrati