Update dependencies and golang from 1.17 to 1.24 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
reviewed
Oct 30, 2025
Contributor
benjyw
left a comment
benjyw
left a comment
There was a problem hiding this comment.
Thanks for this! I think it would be good to have the devcontainer piece in a separate PR though.
Contributor
Author
|
done @benjyw |
benjyw
approved these changes
Oct 30, 2025
Contributor
|
I notice that you pushed the dev container change back onto this or? |
Contributor
|
@stan-dot I can merge this once you revert the devcontainer commit, which somehow got pushed again. Thanks! |
This reverts commit 02ff0ad.
Contributor
Author
|
fixed, that was my mistake |
Contributor
|
Thanks @stan-dot ! If you want to add the devcontainer in a separate PR, feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as in the issue #26 (comment)
upgrade to 1.25 will make
pants test ::fail, so that is as far as we can go now