feat: update to latest shiny JS/CSS assets #2020
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
changed the title
cpsievert
commented
Jun 27, 2025
Comment on lines
+70
to
+75
| # Adds a space between the icon and label | ||
| # TODO: this space gets removed when icon/label are updated dynamically, | ||
| # which is not ideal. The 'right' way to do this would be to either | ||
| # add a CSS class to the separator element, or wrap both the icon and | ||
| # label in a container element. | ||
| " " if icon and label else None, |
There was a problem hiding this comment.
This obviously isn't ideal, and long-term this isn't the approach to spacing that we'd want, but I'm thinking I'll just keep it to retain the current behavior.
There was a problem hiding this comment.
Ugh, the old JS logic would (unconditionally, for both button and links!!) add a space when updating to either the icon or label
https://github.com/rstudio/shiny/blob/33dc41c/srcts/src/bindings/input/actionbutton.ts#L73
This is a big bummer because, unless we add the space in the server-side update, the space gets removed on update 😭
cc @gadenbuie
There was a problem hiding this comment.
Before we make a decision here, I'm gonna look into rstudio/shiny#4249 as a possible direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers this diff rstudio/shiny@ca41c08...460a93a