-
Notifications
You must be signed in to change notification settings - Fork 104
feat: update to latest shiny JS/CSS assets #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cpsievert
wants to merge
2
commits into
main
Choose a base branch
from
feat/update-shiny-assets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"note!": "Generated by scripts/htmlDependencies.R: do not edit by hand", | ||
"package": "shiny", | ||
"version": "1.10.0.9001 (rstudio/shiny@ca41c0831befcf8feea17980a91983ce21d1b8a2)" | ||
"version": "1.11.0.9000 (rstudio/shiny@460a93a5fdc1f152d2ec3d5741a01c2712676526)" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
{ | ||
"note!": "Generated by scripts/htmlDependencies.R: do not edit by hand", | ||
"shiny_version": "1.10.0.9001 (rstudio/shiny@ca41c0831befcf8feea17980a91983ce21d1b8a2)", | ||
"bslib_version": "0.9.0.9000 (rstudio/bslib@7cf80506c6beb9d7e5f2f146d2c9c935bbaf1635)", | ||
"shiny_version": "1.11.0.9000 (rstudio/shiny@460a93a5fdc1f152d2ec3d5741a01c2712676526)", | ||
"bslib_version": "0.9.0.9000 (rstudio/bslib@c707161125dc5646ce2b9990ab474b7cedaef920)", | ||
"htmltools_version": "0.5.8.9000 (rstudio/htmltools@487aa0bed7313d7597b6edd5810e53cab0061198)", | ||
"bootstrap_version": "5.3.1" | ||
} |
Binary file modified
BIN
+72 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvQlMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+656 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvUlMI.woff2
Binary file not shown.
Binary file modified
BIN
+44 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvXlMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+60 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvYlMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+92 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvZlMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+4.62 KB
(120%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvalMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+516 Bytes
(110%)
shiny/www/shared/bootstrap/fonts/HI_QiYsKILxRpg3hIP6sJ7fM7PqlONvblMIXxw.woff2
Binary file not shown.
Binary file modified
BIN
+4.55 KB
(120%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlM-vWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+320 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlMOvWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+164 Bytes
(110%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlMevWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+484 Bytes
(110%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlMuvWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+308 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlOevWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+516 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlPevW.woff2
Binary file not shown.
Binary file modified
BIN
+384 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/HI_SiYsKILxRpg3hIP6sJ7fM7PqlPuvWjMY.woff2
Binary file not shown.
Binary file modified
BIN
+400 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqW106F15M.woff2
Binary file not shown.
Binary file modified
BIN
+56 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWt06F15M.woff2
Binary file not shown.
Binary file modified
BIN
+56 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWtE6F15M.woff2
Binary file not shown.
Binary file modified
BIN
-36 Bytes
(99%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWtU6F15M.woff2
Binary file not shown.
Binary file modified
BIN
+76 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWtk6F15M.woff2
Binary file not shown.
Binary file modified
BIN
+816 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWu06F15M.woff2
Binary file not shown.
Binary file modified
BIN
-56 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWuU6F.woff2
Binary file not shown.
Binary file modified
BIN
+140 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWuk6F15M.woff2
Binary file not shown.
Binary file modified
BIN
-188 Bytes
(99%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWvU6F15M.woff2
Binary file not shown.
Binary file modified
BIN
+5.65 KB
(110%)
shiny/www/shared/bootstrap/fonts/memtYaGs126MiZpBA-UFUIcVXSCEkx2cmqvXlWqWxU6F15M.woff2
Binary file not shown.
Binary file modified
BIN
+96 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTS-muw.woff2
Binary file not shown.
Binary file modified
BIN
+404 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTS2mu1aB.woff2
Binary file not shown.
Binary file modified
BIN
-56 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSCmu1aB.woff2
Binary file not shown.
Binary file modified
BIN
-172 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSGmu1aB.woff2
Binary file not shown.
Binary file modified
BIN
-168 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSKmu1aB.woff2
Binary file not shown.
Binary file modified
BIN
-20 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSOmu1aB.woff2
Binary file not shown.
Binary file modified
BIN
-148 Bytes
(99%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSumu1aB.woff2
Binary file not shown.
Binary file modified
BIN
+60 Bytes
(100%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTSymu1aB.woff2
Binary file not shown.
Binary file modified
BIN
+1.57 KB
(110%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTUGmu1aB.woff2
Binary file not shown.
Binary file modified
BIN
+4.78 KB
(110%)
shiny/www/shared/bootstrap/fonts/memvYaGs126MiZpBA-UvWbX2vVnXBbObj2OVTVOmu1aB.woff2
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"note!": "Generated by scripts/htmlDependencies.R: do not edit by hand", | ||
"package": "bslib", | ||
"version": "0.9.0.9000 (rstudio/bslib@7cf80506c6beb9d7e5f2f146d2c9c935bbaf1635)" | ||
"version": "0.9.0.9000 (rstudio/bslib@c707161125dc5646ce2b9990ab474b7cedaef920)" | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-164 Bytes
(98%)
shiny/www/shared/jqueryui/images/ui-icons_444444_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-141 Bytes
(98%)
shiny/www/shared/jqueryui/images/ui-icons_555555_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-160 Bytes
(97%)
shiny/www/shared/jqueryui/images/ui-icons_777620_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-157 Bytes
(98%)
shiny/www/shared/jqueryui/images/ui-icons_777777_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-160 Bytes
(97%)
shiny/www/shared/jqueryui/images/ui-icons_cc0000_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-136 Bytes
(98%)
shiny/www/shared/jqueryui/images/ui-icons_ffffff_256x240.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This obviously isn't ideal, and long-term this isn't the approach to spacing that we'd want, but I'm thinking I'll just keep it to retain the current behavior.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, the old JS logic would (unconditionally, for both button and links!!) add a space when updating to either the icon or label
https://github.com/rstudio/shiny/blob/33dc41c/srcts/src/bindings/input/actionbutton.ts#L73
This is a big bummer because, unless we add the space in the server-side update, the space gets removed on update 😭
cc @gadenbuie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we make a decision here, I'm gonna look into rstudio/shiny#4249 as a possible direction