Skip to content

Conversation

@JoviDeCroock
Copy link
Member

Currently the cached shape is props.children while the non-cached shape is Item.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: cf673c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@preact/signals-react Patch
@preact/signals Patch
preact-signals-devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 6, 2025

Deploy Preview for preact-signals-demo ready!

Name Link
🔨 Latest commit cf673c5
🔍 Latest deploy log https://app.netlify.com/projects/preact-signals-demo/deploys/6911eabe42f33a000706bfde
😎 Deploy Preview https://deploy-preview-790--preact-signals-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@JoviDeCroock JoviDeCroock force-pushed the correct-result-setting branch from 3b14ef4 to edd8a69 Compare November 6, 2025 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Size Change: -8 B (-0.01%)

Total Size: 106 kB

Filename Size Change
docs/dist/assets/bench.********.js 1.59 kB +1 B (+0.06%)
docs/dist/assets/devtools.********.js 995 B -7 B (-0.7%)
docs/dist/assets/index.********.js 7.04 kB -2 B (-0.03%)
ℹ️ View Unchanged
Filename Size
docs/dist/assets/client.********.js 46.2 kB
docs/dist/assets/jsxRuntime.module.********.js 297 B
docs/dist/assets/preact.module.********.js 4.72 kB
docs/dist/assets/signals-core.module.********.js 1.56 kB
docs/dist/assets/signals.module.********.js 2.56 kB
docs/dist/assets/style.********.css 1.27 kB
docs/dist/assets/style.********.js 21 B
docs/dist/basic-********.js 246 B
docs/dist/nesting-********.js 1.13 kB
docs/dist/react-********.js 242 B
packages/core/dist/signals-core.js 1.59 kB
packages/core/dist/signals-core.mjs 1.6 kB
packages/debug/dist/debug.js 3.64 kB
packages/debug/dist/debug.mjs 3.18 kB
packages/preact-transform/dist/signals-*********.js 1.3 kB
packages/preact-transform/dist/signals-transform.mjs 1.29 kB
packages/preact-transform/dist/signals-transform.umd.js 1.42 kB
packages/preact/dist/signals.js 1.71 kB
packages/preact/dist/signals.mjs 1.66 kB
packages/react-transform/dist/signals-*********.js 6.89 kB
packages/react-transform/dist/signals-transform.mjs 6.09 kB
packages/react-transform/dist/signals-transform.umd.js 7.01 kB
packages/react/dist/signals.js 188 B
packages/react/dist/signals.mjs 150 B

compressed-size-action

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier to follow too, nice!

@JoviDeCroock JoviDeCroock merged commit 4b143a7 into main Nov 10, 2025
6 checks passed
@JoviDeCroock JoviDeCroock deleted the correct-result-setting branch November 10, 2025 13:42
@github-actions github-actions bot mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants