-
Notifications
You must be signed in to change notification settings - Fork 1.1k
change use of measurements to records in tomography #7421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kygnz
wants to merge
10
commits into
quantumlib:main
Choose a base branch
from
kygnz:records
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fca6fd8
change measurements to records
kygnz 38e4cae
Merge branch 'main' into records
kygnz 84d2350
Merge branch 'main' into records
mhucka 535150b
Specify .records to index final measurement only
kygnz 6cfe17d
Merge branch 'main' into records
kygnz 5928f44
added unique key test functionality + test case
kygnz 4d5a975
deleted env
kygnz ec7c434
formatting updates
kygnz af5863b
more formatting updates
kygnz 634fa58
fixed formatting + errors
kygnz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it would be good to check here whether the key
'z'
is being used in the given circuit, and if so pick a unique key. One thing that could still fail is if the key is already used in the circuit to measure two or more qubits (e.g.cirq.measure(q0, q1, key='z')
) then adding another instance here with a single qubit will cause errors when running the circuit.