Skip to content

Remove DONT_CLEAN_BUILD feature flag #12519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove DONT_CLEAN_BUILD feature flag #12519

wants to merge 1 commit into from
+0 −26

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 9, 2025

@stsewd stsewd requested a review from a team as a code owner October 9, 2025 23:05
@stsewd stsewd requested a review from ericholscher October 9, 2025 23:05
humitos
humitos approved these changes Oct 10, 2025
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I know that @ericholscher was testing something in .com with this --but I think it didn't work as expected. So we may need to be sure we are not using it there anymore as well.

ericholscher
ericholscher approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, this was an idea but wasn't used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericholscher ericholscher ericholscher approved these changes

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stsewd @ericholscher @humitos