Skip to content

Remove DONT_CLEAN_BUILD feature flag #12519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove DONT_CLEAN_BUILD feature flag #12519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions readthedocs/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1983,7 +1983,6 @@ def add_features(sender, **kwargs):
SCALE_IN_PROTECTION = "scale_in_prtection"
USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS = "use_s3_scoped_credentials_on_builders"
BUILD_FULL_CLEAN = "build_full_clean"
DONT_CLEAN_BUILD = "dont_clean_build"
BUILD_HEALTHCHECK = "build_healthcheck"
BUILD_NO_ACKS_LATE = "build_no_acks_late"

Expand Down Expand Up @@ -2039,12 +2038,6 @@ def add_features(sender, **kwargs):
USE_S3_SCOPED_CREDENTIALS_ON_BUILDERS,
_("Build: Use S3 scoped credentials for uploading build artifacts."),
),
(
DONT_CLEAN_BUILD,
_(
"Build: Don't clean the build directory. Only for Enterprise users with dedicated builders."
),
),
(
BUILD_FULL_CLEAN,
_("Build: Clean all build directories to avoid leftovers from other projects."),
Expand Down
11 changes: 0 additions & 11 deletions readthedocs/projects/tasks/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,6 @@

def clean_build(version=None):
"""Clean the files used in the build of the given version."""

if version and version.project.has_feature(
Feature.DONT_CLEAN_BUILD,
):
log.info(
"Skipping cleaning build files for project with DONT_CLEAN_BUILD feature.",
project_slug=version.project.slug,
version_slug=version.slug,
)
return

if version:
del_dirs = [
os.path.join(version.project.doc_path, dir_, version.slug)
Expand Down
8 changes: 0 additions & 8 deletions readthedocs/vcs_support/backends/git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ def update(self):
code, stdout, stderr = self.run(*cmd.split(), escape_command=False)
return

# Check for existing checkout and skip clone if it exists.
from readthedocs.projects.models import Feature

if self.project.has_feature(Feature.DONT_CLEAN_BUILD) and os.path.exists(
os.path.join(self.working_dir, ".git")
):
return self.fetch()

self.clone()
# TODO: We are still using return values in this function that are legacy.
# This should be either explained or removed.
Expand Down