Fix issues on bazeldnf and xattr rule invocations #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors like ``` $ bazel run //rpm:ldd_x86_64 DEBUG: /usr/local/google/home/rmohr/.cache/bazel/_bazel_rmohr/4c1501bf8a3fa32b59ed554fc2f4f732/external/bazeldnf/def.bzl:10:10: import this method from @bazeldnf//bazeldnf:defs.bzl ERROR: /usr/local/google/home/rmohr/gerrit/kubevirt/rpm/BUILD.bazel:21:9: in _bazeldnf rule //rpm:ldd_x86_64: Traceback (most recent call last): File "/usr/local/google/home/rmohr/.cache/bazel/_bazel_rmohr/4c1501bf8a3fa32b59ed554fc2f4f732/external/bazeldnf/internal/bazeldnf.bzl", line 18, column 39, in _bazeldnf_impl transitive_dependencies.extend(ctx.attr.tar.files) Error in extend: type 'depset' is not iterable ``` Signed-off-by: Roman Mohr <rmohr@google.com>
By accident arrays of capabilities were added insteads of strings. Fixes errors like ``` ERROR: /usr/local/google/home/rmohr/gerrit/kubevirt/cmd/virt-launcher/BUILD.bazel:73:7: in _xattrs rule //cmd/virt-launcher:blub: Traceback (most recent call last): File "/usr/local/google/home/rmohr/.cache/bazel/_bazel_rmohr/4c1501bf8a3fa32b59ed554fc2f4f732/external/bazeldnf/internal/xattrs.bzl", line 28, column 44, in _xattrs_impl args += ["--capabilities", ",".join(capabilities)] Error in join: expected string for sequence element 0, got 'list' ``` Signed-off-by: Roman Mohr <rmohr@google.com>
|
This was referenced May 30, 2025
There was a problem hiding this comment.
We should use ctx.actions.args instead, it knows how to expand depart when used with joinall and others, but maybe that can wait another PR and not as part of this one
manuelnaranjo
approved these changes
May 30, 2025
Do you have an example pointer? I can do a follow-up. |
|
https://www.stevenengelhardt.com/2020/11/12/practical-bazel-use-ctx.actions.args-to-form-arguments-lists/ there's and add_all_joined that takes a separator as argument, it has slight performance improvements as depsets are only expanded on the build phase and not at analysis |
rmohr
added a commit
to rmohr/kubevirt
that referenced
this pull request
Jun 4, 2025
…patibility The new version has a few fixes which are potentially hit on newer bazel versions due to plugin code changes and is also module ready in principle. Most notably it brings in rmohr/bazeldnf#135.
rmohr
added a commit
to rmohr/kubevirt
that referenced
this pull request
Jun 4, 2025
…patibility The new version has a few fixes which are potentially hit on newer bazel versions due to plugin code changes and is also module ready in principle. Most notably it brings in rmohr/bazeldnf#135. Signed-off-by: Roman Mohr <rmohr@google.com>
brianmcarey
pushed a commit
to brianmcarey/kubevirt
that referenced
this pull request
Jun 5, 2025
…patibility The new version has a few fixes which are potentially hit on newer bazel versions due to plugin code changes and is also module ready in principle. Most notably it brings in rmohr/bazeldnf#135. Signed-off-by: Roman Mohr <rmohr@google.com>
rmohr
added a commit
to rmohr/kubevirt
that referenced
this pull request
Jun 9, 2025
…patibility The new version has a few fixes which are potentially hit on newer bazel versions due to plugin code changes and is also module ready in principle. Most notably it brings in rmohr/bazeldnf#135. Signed-off-by: Roman Mohr <rmohr@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, if bazeldnf is invoked via bazel itself, transitive dependencies are treated as iterables, which is long deprecated and which can fail on newer versions with:
Second, the
xattrrule was not properly constructing the arguments list which seems to only now be visible: