Skip to content

Fix issue with pc breaking in requiredMethod on newly overloaded valueOf #23708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2025
Merged

Fix issue with pc breaking in requiredMethod on newly overloaded valueOf #23708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1d21e3
Fix issue with pc breaking in requiredMethod on newly overloaded valueOf
jchyb Aug 11, 2025
64763fb
Remove the nonexistent ValueOf.valueOf and add ValueOf to the complet…
jchyb Aug 11, 2025
a4d07aa
fix test
jchyb Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions presentation-compiler/src/main/dotty/tools/pc/completions/Completions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,15 +734,18 @@ class Completions(
defn.Object_notifyAll,
defn.Object_notify,
defn.Predef_undefined,
defn.ObjectClass.info.member(nme.wait_).symbol,
// NOTE(olafur) IntelliJ does not complete the root package and without this filter
// then `_root_` would appear as a completion result in the code `foobar(_<COMPLETE>)`
defn.RootPackage,
// NOTE(gabro) valueOf was added as a Predef member in 2.13. We filter it out since is a niche
// use case and it would appear upon typing 'val'
defn.ValueOfClass.info.member(nme.valueOf).symbol,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValueOf.valueOf does not exist and going by the comment, it seems that the ValueOf class was meant to be filtered here instead, so I changed this.

defn.ScalaPredefModule.requiredMethod(nme.valueOf)
).flatMap(_.alternatives.map(_.symbol)).toSet
defn.ValueOfClass
) ++ (
Set(
defn.ObjectClass.info.member(nme.wait_),
defn.ScalaPredefModule.info.member(nme.valueOf)
).flatMap(_.alternatives.map(_.symbol)).toSet
)

private def isNotLocalForwardReference(sym: Symbol)(using Context): Boolean =
!sym.isLocalToBlock ||
Expand Down
3 changes: 0 additions & 3 deletions presentation-compiler/test/dotty/tools/pc/tests/completion/CompletionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ class CompletionSuite extends BaseCompletionSuite:
|isInstanceOf[X0]: Boolean
|synchronized[X0](x$0: X0): X0
|toString(): String
|wait(): Unit
|wait(x$0: Long): Unit
|wait(x$0: Long, x$1: Int): Unit
|""".stripMargin
)

Expand Down
Loading