-
Notifications
You must be signed in to change notification settings - Fork 39
Use PostgreSQL in integration tests by default #2894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the default database for integration tests from MySQL to PostgreSQL to improve performance. The change involves updating default connection parameters in test environment configuration files and adjusting CI workflow commands to maintain database-specific testing.
- Updated default JDBC connection parameters from MySQL to PostgreSQL in test environment classes
- Modified CI workflow to explicitly specify MySQL parameters for MySQL-specific test jobs and use defaults for PostgreSQL jobs
- Replaced MySQL Docker setup with PostgreSQL service configuration in multi-storage integration tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
MultiStorageEnv.java | Updated default JDBC connection from MySQL to PostgreSQL parameters |
JdbcEnv.java | Changed default JDBC URL, username, and password from MySQL to PostgreSQL |
.github/workflows/ci.yaml | Modified test commands to explicitly specify database parameters and updated service configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the default database configuration for integration tests to use PostgreSQL instead of MySQL. The primary motivation for this change is to improve test performance, as PostgreSQL is noted to offer better performance among the databases supported by ScalarDB. The changes involve modifying hardcoded default connection strings in the test environment setup.
Highlights
- Default Database for Integration Tests: The default database used for integration tests has been changed from MySQL to PostgreSQL. This change is driven by the aim to leverage PostgreSQL's superior performance for these tests within ScalarDB.
- JDBC Environment Configuration Update: The default JDBC connection parameters, including the URL, username, and password, have been updated in
JdbcEnv.java
andMultiStorageEnv.java
to point to a PostgreSQL instance instead of MySQL.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request changes the default database for integration tests from MySQL to PostgreSQL, which should offer better performance. The changes involve updating the default JDBC connection details in JdbcEnv.java
and MultiStorageEnv.java
.
core/src/integration-test/java/com/scalar/db/storage/multistorage/MultiStorageEnv.java
Show resolved
Hide resolved
core/src/integration-test/java/com/scalar/db/storage/multistorage/MultiStorageEnv.java
Show resolved
Hide resolved
87e30b1
to
43a6d57
Compare
43a6d57
to
54b4eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Description
This PR changes the default database for integration tests to PostgreSQL, which offers the best performance among the supported databases in ScalarDB.
Related issues and/or PRs
N/A
Changes made
Checklist
Additional notes (optional)
N/A
Release notes
N/A