Skip to content

Use PostgreSQL in integration tests by default #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

brfrn169
Copy link
Collaborator

Description

This PR changes the default database for integration tests to PostgreSQL, which offers the best performance among the supported databases in ScalarDB.

Related issues and/or PRs

N/A

Changes made

  • Changed the default database for integration tests to PostgreSQL

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • I have considered whether similar issues could occur in other products, components, or modules if this PR is for bug fixes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@brfrn169 brfrn169 requested a review from Copilot July 18, 2025 08:08
@brfrn169 brfrn169 self-assigned this Jul 18, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the default database for integration tests from MySQL to PostgreSQL to improve performance. The change involves updating default connection parameters in test environment configuration files and adjusting CI workflow commands to maintain database-specific testing.

  • Updated default JDBC connection parameters from MySQL to PostgreSQL in test environment classes
  • Modified CI workflow to explicitly specify MySQL parameters for MySQL-specific test jobs and use defaults for PostgreSQL jobs
  • Replaced MySQL Docker setup with PostgreSQL service configuration in multi-storage integration tests

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
MultiStorageEnv.java Updated default JDBC connection from MySQL to PostgreSQL parameters
JdbcEnv.java Changed default JDBC URL, username, and password from MySQL to PostgreSQL
.github/workflows/ci.yaml Modified test commands to explicitly specify database parameters and updated service configuration

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @brfrn169, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the default database configuration for integration tests to use PostgreSQL instead of MySQL. The primary motivation for this change is to improve test performance, as PostgreSQL is noted to offer better performance among the databases supported by ScalarDB. The changes involve modifying hardcoded default connection strings in the test environment setup.

Highlights

  • Default Database for Integration Tests: The default database used for integration tests has been changed from MySQL to PostgreSQL. This change is driven by the aim to leverage PostgreSQL's superior performance for these tests within ScalarDB.
  • JDBC Environment Configuration Update: The default JDBC connection parameters, including the URL, username, and password, have been updated in JdbcEnv.java and MultiStorageEnv.java to point to a PostgreSQL instance instead of MySQL.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the default database for integration tests from MySQL to PostgreSQL, which should offer better performance. The changes involve updating the default JDBC connection details in JdbcEnv.java and MultiStorageEnv.java.

@brfrn169 brfrn169 force-pushed the use-postgres-in-ci-by-default branch 2 times, most recently from 87e30b1 to 43a6d57 Compare July 18, 2025 08:29
@brfrn169 brfrn169 force-pushed the use-postgres-in-ci-by-default branch from 43a6d57 to 54b4eed Compare July 18, 2025 08:38
Copy link
Contributor

@Torch3333 Torch3333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@brfrn169 brfrn169 merged commit 819ae90 into master Jul 22, 2025
56 checks passed
@brfrn169 brfrn169 deleted the use-postgres-in-ci-by-default branch July 22, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants