Skip to content

[StateContainer] Deprecated visualization Data #5591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[StateContainer] Deprecated visualization Data #5591

wants to merge 2 commits into from

Conversation

@alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Jul 3, 2025 •
edited
Loading

#5588 and #5590 introduced components to visualize a generic point cloud and vector field. Those features are also present in MechanicalObject through a couple of Data. This is redundant, so this PR removes them.

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 3, 2025
@damienmarchal
Copy link
Contributor

damienmarchal commented Jul 4, 2025 •
edited
Loading

After this one...
this will gives the envy to do the exact same for all showXXXX in every components.

@hugtalbot
Copy link
Contributor

hugtalbot commented Jul 16, 2025

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jul 16, 2025
@damienmarchal damienmarchal mentioned this pull request Jul 17, 2025
Merged
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Jul 31, 2025
@alxbilger
Copy link
Contributor Author

alxbilger commented Jul 31, 2025

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Aug 27, 2025
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 15, 2025
@hugtalbot
Copy link
Contributor

hugtalbot commented Sep 25, 2025

Scene tests are still failing

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Sep 25, 2025
@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Nov 1, 2025
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: clean Cleaning the code pr: status wip Development in the pull-request is still in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alxbilger @damienmarchal @hugtalbot @bakpaul