[Sofa.GUI.Common] Fix the setting of viewer's camera as it is not working properly currently. #5757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. The Node::get() method is by default searching upward. As we are at root node this means that only a camera at root node is detected. This is problematic as it is very usefull to have a camera embeded in some subnode of the scene.
damienmarchal
added
pr: fix
| //currentCamera->d_position.forceSet(); | ||
| //currentCamera->d_orientation.forceSet(); | ||
| currentCamera->bwdInit(); | ||
| msg_warning("BaseViewer") << "There is no camera in this scene, I created one. To remove this error message, add a camera in your scene."; |
There was a problem hiding this comment.
When we build a simulation, we expect users to address the warnings. I don't think adding a camera should be mandatory. So I think an info message would be more appropriate: msg_info("BaseViewer") << A default camera has been added because none was found in the scene graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only a camera at the root node of the scene is detected during initialization of the BaseViewer.
This is problematic as it is very usefull to have a camera embeded in some subnode of the scene.
The problem is because the Node::get() method with default parameter is searching "upward". As we are at root node this means that only a camera at root node is detected. It would be searching in the node and downward.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if