feat: Allow to use an existing translator #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The missing translations will therefore appears in the Web Profiler : 
|
Owner
|
May you add it as second parameter to not change parameter order? It adds breaking change when passed as first param. |
Contributor
Author
@sokil Done 👍🏻 |
Contributor
Author
|
Thanks @sokil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and context
With the existing implementation, we cannot see potential missing translations and add them in our own translations files.
Proposal
With this PR, we can use the existing translator from symfony that allow us to see the missing translations + add potential missing translations.
Breaking change ?
None as the parameter is only used if it's not null and it'll be null by default.