Update CI jobs to remove unnecessary npm config and use of setup-node #4117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
AlanGreene
force-pushed
the
npm_cache
branch
2 times, most recently
from
87388eb to
75b2157
Compare
tekton-robot
added
size/M
AlanGreene
force-pushed
the
npm_cache
branch
2 times, most recently
from
d187c4f to
3344e31
Compare
tekton-robot
added
size/S
AlanGreene
changed the title
tekton-robot
added
the
needs-rebase
There's no need to change the npm prefix as we don't rely on global package installs for any of the CI jobs. Also remove `setup-node` usage from the build test job as it only needs go. This cuts the time for the build job in half.
tekton-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There's no need to change the npm prefix as we don't rely on global package installs for any of the CI jobs.
Also remove
setup-nodeusage from the build test job as it only needs go. This cuts the time for the build job by over half (~2.5 mins to <1min)./kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes