Skip to content

Conversation

cmanzur
Copy link
Contributor

@cmanzur cmanzur commented Oct 7, 2025

Description

Support transit_encryption_enabled for all Engines

Motivation and Context

transit_encryption_enabled was disabled by default for Redis Engine.

Resolves #55

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@cmanzur cmanzur changed the title chore: support transit_encryption_enabled for all engines chore: Support transit_encryption_enabled for all engines Oct 7, 2025
@cmanzur cmanzur changed the title chore: Support transit_encryption_enabled for all engines chore: Support transit_encryption_enabled for all engines Oct 7, 2025
@bryantbiggs bryantbiggs changed the title chore: Support transit_encryption_enabled for all engines fix: Enable transit_encryption_enabled for all avialble engines now that Elasticache supports this Oct 7, 2025
@bryantbiggs bryantbiggs merged commit 2ee85ee into terraform-aws-modules:master Oct 7, 2025
16 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 7, 2025
## [1.10.1](v1.10.0...v1.10.1) (2025-10-07)

### Bug Fixes

* Enable `transit_encryption_enabled` for all avialble engines now that Elasticache supports this ([#56](#56)) ([2ee85ee](2ee85ee))
@antonbabenko
Copy link
Member

This PR is included in version 1.10.1 🎉

@manelpb
Copy link

manelpb commented Oct 7, 2025

This was supposed to be released as a breaking change. As soon the module version was updated, clusters were trying to be recreated because of this default variable.

      ~ transit_encryption_enabled   = false -> true # forces replacement

cc @bryantbiggs @antonbabenko

bryantbiggs added a commit to bryantbiggs/terraform-aws-elasticache that referenced this pull request Oct 7, 2025
@bryantbiggs
Copy link
Member

apologies for that - the removal of the prior restriction appears to clash with the current default behavior of the module to enforce encryption

we'll revert for now in #57 and save this change for an upcoming breaking change that will be released under a new major version number

bryantbiggs added a commit that referenced this pull request Oct 8, 2025
antonbabenko pushed a commit that referenced this pull request Oct 8, 2025
## [1.10.2](v1.10.1...v1.10.2) (2025-10-08)

### Bug Fixes

* Revert - Enable `transit_encryption_enabled` for all avialble engines now that Elasticache supports this [#56](#56) ([#57](#57)) ([b241dc0](b241dc0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support transit_encryption_enabled for Redis Engine

4 participants