DOC-3147: Tab to create a new row in tables with a non-editable final row would freeze the editor. #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… row would freeze the editor.
kemister85
requested review from
abhinavgandham,
soritaheng and
a team
as code owners
kemister85
added
the
upcoming release
kemister85
requested review from
EkimChau,
ShiridiGandham and
MitchC1999
and removed request for
a team
HAFRMO
approved these changes
Jun 24, 2025
|
|
||
| Previously, when attempting to create a new row by pressing Tab in a table with a non-editable final row, the editor would freeze causing a infinite loop of insert attempts. This was due to the logic not correctly detecting whether the last row was editable, leading to repeated, unsuccessful insert attempts. | ||
|
|
||
| {productname} {release-version} fixes this issue by correctly detecting whether the last row is editable, allowing the user to create a new row without freezing the editor. |
There was a problem hiding this comment.
Not quite correct, sorry for forgetting the docs.
Previously it didn't detect that the last row was readonly when tabbed into from above and instead created a copy of it. When attempting to place the cursor into it it found that it couldn't ( readonly after all ) and so created another copy and tried to go into that. This would then repeat until error.
The change is that it now detects that the last row is readonly and aborts creating another row before one has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: DOC-3147
Site: Staging branch
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.Review: