Skip to content

DOC-3147: Tab to create a new row in tables with a non-editable final row would freeze the editor. #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/8.0.0/DOC-3147
Choose a base branch
from
Open

DOC-3147: Tab to create a new row in tables with a non-editable final row would freeze the editor. #3768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions modules/ROOT/pages/8.0-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ For information on using Enhanced Skins & Icon Packs, see: xref:enhanced-skins-a

// CCFR here.

=== Tab to create a new row in tables with a non-editable final row would freeze the editor.
// #TINY-12018

Previously, when attempting to create a new row by pressing Tab in a table with a non-editable final row, the editor would freeze causing a infinite loop of insert attempts. This was due to the logic not correctly detecting whether the last row was editable, leading to repeated, unsuccessful insert attempts.

{productname} {release-version} fixes this issue by correctly detecting whether the last row is editable, allowing the user to create a new row without freezing the editor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite correct, sorry for forgetting the docs.

Previously it didn't detect that the last row was readonly when tabbed into from above and instead created a copy of it. When attempting to place the cursor into it it found that it couldn't ( readonly after all ) and so created another copy and tried to go into that. This would then repeat until error.

The change is that it now detects that the last row is readonly and aborts creating another row before one has been added.



[[security-fixes]]
== Security fixes
Expand Down