fix: make source optional #819
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .string() | ||
| .allow(null) | ||
| .default(INVITE_SOURCE.WORK_MANAGER) | ||
| .custom((value) => { |
There was a problem hiding this comment.
The custom function here is converting null to undefined. Consider explaining why this conversion is necessary, as it might affect how the source field is handled downstream. Ensure that this change aligns with the intended behavior of making the source optional.
| source: Joi.string() | ||
| source: Joi | ||
| .string() | ||
| .valid(_.values(INVITE_STATUS)) |
There was a problem hiding this comment.
The valid method is being used with INVITE_STATUS, but it seems like it should be used with INVITE_SOURCE instead, as source is expected to be a string representing the invite source. Please verify if this is the intended behavior.
| source: Joi.string() | ||
| source: Joi | ||
| .string() | ||
| .valid(_.values(INVITE_SOURCE)) |
There was a problem hiding this comment.
The change from INVITE_STATUS to INVITE_SOURCE seems to align with the pull request description of making the source field optional. However, ensure that INVITE_SOURCE is correctly defined and imported in this context, and that it contains the appropriate values for validation.
1 participant
What's in this PR?