Skip to content

fix: make source optional #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

fix: make source optional #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
82b6522
fix: make source optiona;
hentrymartin Jun 16, 2025
42c5a4b
fix: make source optiona;
hentrymartin Jun 16, 2025
ad8ddc0
fix: make source optiona;
hentrymartin Jun 16, 2025
0ae0be4
fix: make source optiona;
hentrymartin Jun 16, 2025
c245bc7
fix: make source optiona;
hentrymartin Jun 16, 2025
b37e999
fix: send source only if its available
hentrymartin Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ workflows:
context : org-global
filters:
branches:
only: ['develop', 'migration-setup', 'pm-1173_1']
only: ['develop', 'migration-setup', 'pm-1355_1']
- deployProd:
context : org-global
filters:
Expand Down
4 changes: 3 additions & 1 deletion src/routes/projectMemberInvites/update.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ const updateMemberValidations = {
status: Joi.any()
.valid(_.values(INVITE_STATUS))
.required(),
source: Joi.string()
source: Joi
.string()
.valid(_.values(INVITE_SOURCE))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change from INVITE_STATUS to INVITE_SOURCE seems to align with the pull request description of making the source field optional. However, ensure that INVITE_SOURCE is correctly defined and imported in this context, and that it contains the appropriate values for validation.

.default(INVITE_SOURCE.WORK_MANAGER),
})
.required(),
Expand Down