Skip to content

Don't open welcome page on extension update #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Dineshs91
Copy link
Contributor

@Dineshs91 Dineshs91 commented Apr 16, 2025

TL;DR

Simplified the extension's onInstalled event handler to only open the welcome page on initial installation, not on updates.

What changed?

  • Removed the condition that checks for "update" reason in the onInstalled event listener
  • Removed the URL parameter ?updated=true that was previously added for update events
  • Simplified the welcome page URL to always be https://typefully.com/minimal-twitter/welcome without any query parameters

How to test?

  1. Install the extension for the first time and verify the welcome page opens
  2. Update the extension and verify the welcome page does not open
  3. Trigger other installation events and verify the welcome page does not open

Why make this change?

This change improves user experience by only showing the welcome page to new users, preventing interruptions for existing users when the extension updates. This reduces potential annoyance from having the welcome page repeatedly open after extension updates.

Fix MIN-36

Copy link
Contributor Author

Dineshs91 commented Apr 16, 2025

Copy link
Contributor Author

Dineshs91 commented Apr 30, 2025

Merge activity

  • Apr 30, 11:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 30, 11:26 AM EDT: @Dineshs91 merged this pull request with Graphite.

@Dineshs91 Dineshs91 merged commit 9fdf1a7 into main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants