Fix notification count and red dot not hidden in title #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
linuz90
approved these changes
Apr 28, 2025
When notifications in title is turned off
Dineshs91
force-pushed
the
dinesh/04-16-fix_notification_count_and_red_dot_not_hidden_in_title
branch
from
52a172c to
3b10bc3
Compare
Dineshs91
force-pushed
the
dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable
branch
from
a1900dc to
0399e8d
Compare
Merge activity
|
Dineshs91
changed the base branch from
dinesh/04-16-in_zen_mode_overflowing_content_should_be_scrollable
to
graphite-base/242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Title Notifications Feature
Updates the title notifications feature to work with the latest X/Twitter favicon naming convention, changing references from
twitter.icototwitter.3.icoandtwitter-pip.2.icototwitter-pip.3.ico. Also adds the title notifications feature to the dynamic features module so it can be toggled at runtime.When notifications in title is turned off, the feature now properly restores the original favicon by replacing
-pip.3with.3in the favicon URL.I am also calling
changeNotificationsTitlefunction fromdynamic.jsto handle case where notifications show up while I am already active on Twitter/XFix MIN-30 and #165