Skip to content

Conversation

ehofesmann
Copy link
Member

@ehofesmann ehofesmann commented Aug 13, 2025

Rationale

A customer didn't know that CAS had a separate DB or how to configure that name, this adds comment to values.yaml at at least call it out in one additional location

Checklist

  • This PR maintains parity between Docker Compose and Helm

This brings us closer to docker compose parity which calls it out in the .env:

CAS_DATABASE_NAME=fiftyone-cas

Testing

Signed-off-by: Eric Hofesmann <ehofesmann@gmail.com>
@ehofesmann ehofesmann requested a review from a team as a code owner August 13, 2025 13:06
Copy link

coderabbitai bot commented Aug 13, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • helm/values.yaml is excluded by !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch helm-cas-db-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ehofesmann ehofesmann self-assigned this Aug 13, 2025
@afoley587
Copy link
Member

Isn't this redundant with

?

helm.fiftyone.ai also has this env var documented

Screenshot 2025-08-13 at 9 08 39 AM

@ehofesmann
Copy link
Member Author

ehofesmann commented Aug 13, 2025

Isn't this redundant with

?
helm.fiftyone.ai also has this env var documented

Screenshot 2025-08-13 at 9 08 39 AM

Intentionally redundant, yes.

I don't expect anyone that is new to FiftyOne to read through a thousand of lines of this values.yaml or the table of hundreds of env vars without their eyes glazing over

And since this is a variable that is more likely to need to be changed compared to many of the others, it makes sense to me to call it out here

Comment on lines +83 to +84
# Set the name of the Mongo database for CAS if not using the default `cas`
# CAS_DATABASE_NAME: your-cas-name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a quickstart (simple example) values file. This is already documented in the "real" values file helm/fiftyone-teams-app/values.yaml that also gets added to the helm/fiftyone-teams-app/README.md.

Yep. It's confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def confusing, but still is adding this an issue?

We have similar callouts in that example as well:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It becomes a maintenance question. Which things are deemed important enough to make it to the example? It is likely already very out of date.

@afoley587
Copy link
Member

Please target to release/v2.11.0

@swheaton
Copy link
Contributor

@ehofesmann retarget to v2.11.0, get review, and merge asap if you want this in v2.11.0 documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants