Skip to content

Update values.yaml to include comment about CAS db name #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update values.yaml to include comment about CAS db name #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ appSettings:
casSettings:
env:
FIFTYONE_AUTH_MODE: legacy
# Set the name of the Mongo database for CAS if not using the default `cas`
# CAS_DATABASE_NAME: your-cas-name
Comment on lines +83 to +84
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is a quickstart (simple example) values file. This is already documented in the "real" values file helm/fiftyone-teams-app/values.yaml that also gets added to the helm/fiftyone-teams-app/README.md.

Yep. It's confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def confusing, but still is adding this an issue?

We have similar callouts in that example as well:

fiftyone-teams-app-deploy/helm/values.yaml

Line 104 in 40accf0

# env:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It becomes a maintenance question. Which things are deemed important enough to make it to the example? It is likely already very out of date.


# delegatedOperatorExecutorSettings:
# enabled: true
Expand Down
Loading