Off By One error for BYSETPOS #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For recurring events with positive BYSETPOS values, events were showing up off by one. For example: Labor Day (as created by Zimbra) had the following RRULE: FREQ=YEARLY;INTERVAL=1;BYMONTH=9;BYDAY=MO;BYSETPOS=1 BYSETPOS is One-Based Indexing while array_slice(...) uses Zero-Based Indexing.
Off By One Error for BYSETPOS
|
I am not maintaining this software (and never have), so I am not accepting pull requests. Judging from the sourceforge page, the project has no active maintainer. If you want to revive it, please go ahead. |
joelpittet
referenced
this pull request
in ubc-cpsc/phpicalendar
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For recurring events with positive BYSETPOS values, events were showing up off by one.
For example:
Labor Day (as created by Zimbra) has the following RRULE:
FREQ=YEARLY;INTERVAL=1;BYMONTH=9;BYDAY=MO;BYSETPOS=1
BYSETPOS is One-Based Indexing while array_slice(...) uses Zero-Based Indexing.