Skip to content

Off By One error for BYSETPOS #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Off By One error for BYSETPOS #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78c7719
Off By One Error for BYSETPOS
lenkawamoto Aug 29, 2018
b62062f
Merge pull request #1 from lenkawamoto/lenkawamoto-patch-1
lenkawamoto Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions functions/parse/recur_functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,13 @@ function restrict_bysetpos($times, $freq = '') {
sort($times);
$new_times = array();
foreach ($bysetpos as $setpos) {
// For positive values, we need to adjust for
// Zero-Based Indexing.
$nSetPos = (int)$setpos;
if ($nSetPos > 0)
{
$nSetPos -= 1;
}
$new_times[] = implode('', array_slice($times, $setpos, 1));
}
return $new_times;
Expand Down