Remove esptool copy, add flasher stubs copy #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekmatej
requested review from
LucasTambor,
raffarost,
sylvioalves and
wmrsouza
as code owners
wmrsouza
approved these changes
Jul 9, 2025
marekmatej
force-pushed
the
feature/esptool_flasher_stubs
branch
2 times, most recently
from
722b228 to
5b769fb
Compare
marekmatej
force-pushed
the
feature/esptool_flasher_stubs
branch
from
5b769fb to
db322e6
Compare
wmrsouza
approved these changes
Jul 16, 2025
raffarost
approved these changes
Jul 16, 2025
wmrsouza
approved these changes
Jul 22, 2025
added 3 commits
July 23, 2025 15:05
Remove hard-copy of the esptool in the esptool_py folder and use the esptool from Zephyr environment. Signed-off-by: Marek Matej <marek.matej@espressif.com>
Replace esptool hosted flasher_stub by the snapshot of the https://github.com/espressif/esptool-legacy-flasher-stub (sha256: bd267d361412dbbba410cc36c6e7aa58812fc1bd) Signed-off-by: Marek Matej <marek.matej@espressif.com>
Use package-managers to provide hal requirements.txt. Update the generator script accordingly and add the actual `requirements.txt` file. Fix the path used to access the flash_stub. Signed-off-by: Marek Matej <marek.matej@espressif.com>
marekmatej
force-pushed
the
feature/esptool_flasher_stubs
branch
from
db322e6 to
f5096b5
Compare
LucasTambor
approved these changes
Jul 23, 2025
sylvioalves
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we are removing the esptool copy because it is installed as a package in the Zephyr environment. File
zephyr/requirements.txtis used to hold the hal_espressif requirements.zephyr/module.ymland its generator script are updated to use thepackage-managersentry.The
flasher_stubscopy from its current repository (https://github.com/espressif/esptool-legacy-flasher-stub) is added as well, as it was removed from the esptool, and its files are used in the hal_espressif.