Skip to content

Conversation

maass-hamburg
Copy link
Member

use the default speeds dt prop introduced here #89210 for phy_mii also on the other phys.

@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch 2 times, most recently from 2785c29 to b76ec40 Compare June 13, 2025 13:24
@maass-hamburg maass-hamburg marked this pull request as ready for review June 13, 2025 14:01
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch 3 times, most recently from 185bb90 to 0a2ddba Compare June 17, 2025 14:28
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch from 62e692e to dda4d30 Compare June 18, 2025 08:45
@maass-hamburg maass-hamburg force-pushed the ethernet_phy_default_speeds_all_phys branch from 2f6c139 to 5e306fb Compare July 9, 2025 13:32
@maass-hamburg maass-hamburg requested a review from rruuaanng July 9, 2025 13:35
@rruuaanng rruuaanng self-assigned this Jul 9, 2025
rruuaanng
rruuaanng previously approved these changes Jul 17, 2025
@maass-hamburg
Copy link
Member Author

ping @decsny @lmajewski @pdgendt @clamattia

Copy link
Contributor

@clamattia clamattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f4e2b8d has duplicated signed-off-by.

Also consider a separate PR for f4e2b8d and e819c76 . It is unrelated to default speeds.

move adi,adin1110.yaml adi,adin2111.yaml
from the phy subdir back into the ethernet dir.
They are ethernet controller bindings, not phy bindings.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
fixed link mode is a mode where we don't comunicate with the phy,
therefore we don't need it in other phys as the generic phy_mii one.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
split ethernet-phy.yaml, so that parts, that are used
by other phys are separated.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
remove the use of phy_configure_link() in the ethernet drivers.
The user can now select the default speeds via DT prop, doing
another phy_configure_link() in the eth driver would overwrite
that.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
put the macro to get the default speeds into a
shared header for the phys.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds from dt to configure phy on init.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
use default speeds dt prop

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@maass-hamburg
Copy link
Member Author

f4e2b8d has duplicated signed-off-by.

Also consider a separate PR for f4e2b8d and e819c76 . It is unrelated to default speeds.

@clamattia #91726 contained the two commit too and it it now merged, so this PR no longer has these commits.

Rebased because of that and because there were confilcts.

Copy link

Copy link
Contributor

@clamattia clamattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can see.

@fabiobaltieri fabiobaltieri merged commit edaafb5 into zephyrproject-rtos:main Jul 24, 2025
26 checks passed
@maass-hamburg maass-hamburg deleted the ethernet_phy_default_speeds_all_phys branch July 25, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<err> eth_nxp_enet_mac: phy_configure_link failed with error: -88 eth_nxp_enet_mac failed with -120
7 participants