Fix polygon manipulator aabb computation #903
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/nbl/asset/IPolygonGeometry.h
Outdated
Comment on lines
192
to
193
| static const size_t JOINT_COUNT_PER_VERTEX = 4; | ||
|
|
There was a problem hiding this comment.
huh ?
- Misleading name, the joints per vertex is an upper bound, also it comes from format channel counts across the joint weight views
- should be
constexpr static inlineotherwise you mess up linking - Wrong naming convention, capital snake case is for macros only, constants are capital starting camel case
There was a problem hiding this comment.
actually just remove it
| @@ -72,14 +72,20 @@ class NBL_API2 CPolygonGeometryManipulator | |||
| { | |||
| if (!geo->isSkinned()) return false; | |||
| constexpr auto jointCountPerVertex = ICPUPolygonGeometry::SJointWeight::JOINT_COUNT_PER_VERTEX; | |||
| for (auto& weightView : geo->getJointWeightViews()) | |||
| const auto jointViewCount = geo->getJointWeightViews().size(); | |||
There was a problem hiding this comment.
compute this at start of function outside the lambda
Comment on lines
83
to
85
| for (auto channel_i = 0; channel_i < getFormatChannelCount(weightView.weights.composed.format); channel_i++) | ||
| if (weight[channel_i] > 0.f) | ||
| return true; |
There was a problem hiding this comment.
just do this for all views, I'm not sure I put a hard requirement that all weight and index views must have 4 component format (I just put a req that component count must match for each weight-index pair)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AABB computation on cpu polygon geometry