Skip to content

Fix polygon manipulator aabb computation #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 26, 2025
Merged

Fix polygon manipulator aabb computation #903

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
138d326
Fix compute aabb implementation
Jul 17, 2025
0899273
Implement jointNode exclusion
Jul 28, 2025
6579b28
Merge branch 'mesh_loaders_kevin' into fix_polygon_manipulator_aabb_c…
Jul 29, 2025
f6ad718
Merge branch 'master' into fix_polygon_manipulator_aabb_computation
Aug 12, 2025
4ac6882
Merge branch 'master' into fix_polygon_manipulator_aabb_computation
Aug 19, 2025
f34bf49
Small fix
Aug 19, 2025
1c7d640
Fix logic
Aug 19, 2025
a5af142
Fix logic
Aug 20, 2025
976aeac
Remove JOINT_COUNT_PER_VERTEX
Aug 20, 2025
7723c2f
Don't assume only last channel have less than 4 component
Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 42 additions & 14 deletions include/nbl/asset/utils/CPolygonGeometryManipulator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,48 @@ class NBL_API2 CPolygonGeometryManipulator
}

//
static inline IGeometryBase::SAABBStorage computeAABB(const ICPUPolygonGeometry* geo)
{
if (!geo || !geo->getPositionView() || geo->getPositionView().composed.rangeFormat>=IGeometryBase::EAABBFormat::Count)
return {};
// the AABB shall be the same format as the Position View's range Format
IGeometryBase::SAABBStorage retval;
//if (geo->getIndexView() || geo->isSkinned())
{
// TODO: kevinyu
}
//else
retval = geo->getPositionView().composed.encodedDataRange;
return retval;
}
static inline IGeometryBase::SAABBStorage computeAABB(const ICPUPolygonGeometry* geo)
{
if (!geo || !geo->getPositionView() || geo->getPositionView().composed.rangeFormat>=IGeometryBase::EAABBFormat::Count)
return {};
// the AABB shall be the same format as the Position View's range Format
if (geo->getIndexView() || geo->isSkinned())
{
auto addToAABB = [&](auto& aabb)->void
{
using aabb_t = std::remove_reference_t<decltype(aabb)>;
for (auto i = 0; i != geo->getIndexView().getElementCount(); i++)
{
uint32_t vertex_i;
const auto indexBuffer = geo->getIndexView().getPointer();
switch (geo->getIndexType())
{
case EIT_16BIT:
vertex_i = reinterpret_cast<const uint16_t*>(indexBuffer)[i];
break;
case EIT_32BIT:
vertex_i = reinterpret_cast<const uint32_t*>(indexBuffer)[i];
break;
default:
assert(false);
break;
}
typename aabb_t::point_t pt;
geo->getPositionView().decodeElement(vertex_i, pt);
aabb.addPoint(pt);
}
};
IGeometryBase::SDataViewBase tmp = geo->getPositionView().composed;
tmp.resetRange();
tmp.visitRange(addToAABB);
return tmp.encodedDataRange;
}
else
{
return geo->getPositionView().composed.encodedDataRange;
}
}

static inline void recomputeAABB(const ICPUPolygonGeometry* geo)
{
if (geo->isMutable())
Expand Down
Loading