Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 217: Build ID 2751063 #10982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

dotnet-bot
Copy link
Contributor

@dotnet-bot dotnet-bot commented Jul 16, 2025

Fixes #10918
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

Microsoft Reviewers: Open in CodeFlow

@dotnet-bot dotnet-bot requested a review from a team as a code owner July 16, 2025 05:29
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jul 16, 2025
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.45463%. Comparing base (7fa8965) to head (0541269).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10982         +/-   ##
===================================================
+ Coverage   13.41808%   13.45463%   +0.03655%     
===================================================
  Files           3319        3319                 
  Lines         664894      664894                 
  Branches       74674       74674                 
===================================================
+ Hits           89216       89459        +243     
+ Misses        573130      572883        -247     
- Partials        2548        2552          +4     
Flag Coverage Δ
Debug 13.45463% <ø> (+0.03655%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@harshit7962 harshit7962 merged commit 0567cc2 into main Jul 16, 2025
8 checks passed
@harshit7962 harshit7962 deleted the locfiles/aa7f4bab-0239-4a0a-ae8f-ba9aa8d3bf3a branch July 16, 2025 09:10
@@ -4805,7 +4805,7 @@ Do you want to replace it?</source>
</trans-unit>
<trans-unit id="ScrollBar_ContextMenu_Top">
<source>Top</source>
<target state="translated">- </target>
<target state="translated"></target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the translation is correct.

Because the translation of ScrollBar_ContextMenu_Bottom is 最下部

<trans-unit id="ScrollBar_ContextMenu_Bottom">
<source>Bottom</source>
<target state="translated">最下部</target>
<note />
</trans-unit>

That I think the translation of ScrollBar_ContextMenu_Top should be 最上部 in ja

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it should be "最上部".

The term "最上部" is also used in the .NET Framework.
ScrollButtonMenu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neelabo It seems be fixed in #10993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Localization issue with vertical ScrollBar context menu in Japanese
4 participants