Build: Really test on Firefox ESR, new & old; simplify cache #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
firefox-esr-tests-fixes
branch
2 times, most recently
from
d24eeff to
b8eb451
Compare
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Sep 12, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquerygh-597 Ref jquery/jquery#5682
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquerygh-598 Ref jquery/jquery#5682
mgol
force-pushed
the
firefox-esr-tests-fixes
branch
from
b8eb451 to
efcf81a
Compare
mgol
added
the
Discuss in Meeting
mgol
force-pushed
the
firefox-esr-tests-fixes
branch
2 times, most recently
from
e204bf9 to
ec89ee5
Compare
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows.
mgol
force-pushed
the
firefox-esr-tests-fixes
branch
from
ec89ee5 to
d51106c
Compare
timmywil
approved these changes
Sep 12, 2025
mgol
changed the title
mgol
removed
Needs review
Discuss in Meeting
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Ref jquery/jquery-migrate#597
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Ref jquery/jquery-migrate#597
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Ref jquery/jquery-migrate#597 Ref jquerygh-5702
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Ref jquery/jquery-migrate#597 Ref jquerygh-5703
mgol
added a commit
that referenced
this pull request
Sep 15, 2025
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Also, Simplify caching in CI: our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Closes gh-598 Ref gh-597 Ref jquery/jquery#5682
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Sep 15, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Closes gh-5702 Ref jquery/jquery-migrate#597 Ref gh-5703
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Sep 15, 2025
Our setup is pretty standard, so manual configuration of `actions/cache` is an overkill. Relying on built-in `actions/node` caching will also resolve differences between caching configurations for macOS/Linux vs. Windows. Also, switch from `npm install` to `npm ci` in CI. Closes gh-5703 Ref gh-5702 Ref jquery/jquery-migrate#597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms.
Also, Simplify caching in CI: our setup is pretty standard, so manual configuration of
actions/cacheis an overkill. Relying on built-inactions/nodecaching will also resolve differences between caching configurations for macOS/Linux vs. Windows.Ref gh-598
Ref jquery/jquery#5682
3.xversion: #598