-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: add container status resource metrics from runtime state #2773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add container status resource metrics from runtime state #2773
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrIncompetent The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @mrIncompetent! |
a017dba
to
37915d3
Compare
I believe this is a duplicate of #2702 isn't it? |
Mostly it is, with slight differences:
Edit: |
Expose Pod.Status.ContainerStatuses[i].Resources as new metrics to provide visibility into actual container runtime resource allocation versus desired pod specification. Includes metrics for both regular and init containers. The new metrics track currently applied resource limits and requests as reported by the container runtime, which may differ from pod spec during in-place resource updates. Adds: - kube_pod_container_status_resource_limits - kube_pod_container_status_resource_requests - kube_pod_init_container_status_resource_limits - kube_pod_init_container_status_resource_requests
37915d3
to
dbab46d
Compare
What this PR does / why we need it:
The new metrics track currently applied resource limits and requests as reported by the container runtime, which may differ from pod spec during in-place resource updates.
Adds:
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Adds 4 new metric families with the same label dimensions as existing container resource metrics (
container
,namespace
,node
,pod
,resource
,uid
,unit
). The cardinality increase is proportional to the number of containers and init containers across all pods.