[from_pretrained] Small refactor from_pretrained: move around unrelated stuff
#41445
+627
−548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
changed the title
from_pretrained] Refactor from_pretrained: unbloat, separate and simplify?from_pretrained] Small efactor from_pretrained: move around unrelated stuff
ArthurZucker
changed the title
from_pretrained] Small efactor from_pretrained: move around unrelated stufffrom_pretrained] Small refactor from_pretrained: move around unrelated stuff
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
reviewed
Oct 8, 2025
Co-authored-by: Cyril Vallez <cyril.vallez@huggingface.co>
…ormers into dynamic-weight-loader
This was referenced Oct 9, 2025
…ormers into dynamic-weight-loader
ArthurZucker
force-pushed
the
dynamic-weight-loader
branch
from
cd32b80 to
155b44e
Compare
ArthurZucker
force-pushed
the
dynamic-weight-loader
branch
from
e8e48ef to
06515b6
Compare
|
[For maintainers] Suggested jobs to run (before merge) run-slow: fbgemm_fp8, finegrained_fp8 |
|
Can you really delete |
|
Oh, fixed by #41613, I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As we are moving towards having a dynamic weight loader, we need to have a simple
from_pretrainedcall.This should help