Add share link button to time panel context menu #11186
Conversation
IsseW
added
📺 re_viewer
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
IsseW
force-pushed
the
isse/time-context-menu-links
branch
from
7297e91 to
255c9d1
Compare
IsseW
force-pushed
the
isse/url-context
branch
from
675341a to
fc7f16d
Compare
IsseW
force-pushed
the
isse/time-context-menu-links
branch
from
255c9d1 to
fc7e5de
Compare
IsseW
force-pushed
the
isse/time-context-menu-links
branch
from
f302874 to
616ab1c
Compare
IsseW
force-pushed
the
isse/time-context-menu-links
branch
from
616ab1c to
bdca0ac
Compare
IsseW
added
ui
| /// Information about what this url can do, can be used to hide UI for | ||
| /// sharing when we know it won't work. | ||
| /// | ||
| /// This should be kept up to date with what `ViewerOpenUrl::new` does | ||
| // TODO(isse): I don't really like how this has to be kept up to date manually with | ||
| // `ViewerOpenUrl`, would be nice to consolidate. | ||
| pub fn features(&self, store_hub: &crate::StoreHub) -> Option<UrlFeatures> { |
There was a problem hiding this comment.
I get how you arrived here but I very much concur that this is nasty to maintain.
Alternative suggestion: Where this is used right now we can just create the url with all the needed context and then see if the data we put in "sticks"
There was a problem hiding this comment.
I think maybe better to just always show them for now tbh. The problem with creating the url and why I created this structure to begin with was to try avoid moving ViewerOpenUrl to a lower crate. And the time panel does not have access to it.
There was a problem hiding this comment.
ohhh didn't realize this was in re_viewer_context. That complicates things 🤔
There was a problem hiding this comment.
Moved ViewerOpenUrl to re_viewer_context now, and I think it's much nicer
|
I thiiiink this is a known bug in egui to do a line wrap here when it shouldn't, but worth a quick poke 
|
| /// Copies the given url to the clipboard. | ||
| /// | ||
| /// On web this adds the viewer url as the base url. | ||
| CopyViewerUrl(String), |
There was a problem hiding this comment.
good workaround/disentanglement/clarification!
| /// Origin used to show the examples ui in the redap browser. | ||
| /// | ||
| /// Not actually a valid origin. | ||
| pub static EXAMPLES_ORIGIN: LazyLock<re_uri::Origin> = LazyLock::new(|| re_uri::Origin { |
There was a problem hiding this comment.
much better place for this, agreed.
| re_log_encoding = { workspace = true, features = [ | ||
| "decoder", | ||
| "encoder", | ||
| "stream_from_http", | ||
| ] } |
There was a problem hiding this comment.
a bit unfortunate to have this and re_data_source come in here now (no idea if they were already transitive dependencies), but willing to pay that price for the refactors in this PR
Yeah I've looked at that, and tried to set the context menu to a fixed size. But that happens specifically if you first open the context menu with the shorter text, i.e "Copy link to timestamp" and then open the longer one. If you do it the other way around it doesn't wrap. Maybe I could somehow reset egui memory of the size before it opens, but feels really hacky :/ |
Related
What
Adds share buttons to timeline context menus (left click) as described in #10817